Repository navigation
Dead / Faulty code in ArrayEach? #255
Description
Activity
The API is really uncomfortable to write and I also faced the exact same issue.
I opened the #253 for the same issue and also raised the PR #254 to show a proof of concept.
The API proposed is like
next, err := jsonparser.ArrayIterator(data, "menu", "items") if err != nil { // handle error } for v, t, o, e := next(); e == nil; v, t, o, e = next() { // do anything or break when required }
If that interests you, you can support & suggest your feedback on that also.
- added a commit that references this issue
on Jul 28, 2026 Implemented in v1.4.0 —
ArrayEachErrreturns (count, err) and the callback can return an error to break iteration. The old ArrayEach is unchanged for backward compatibility. See: https://github.com/buger/jsonparser/releases/tag/v1.4.0Reacted by Marcel
Hey,
I've been trying to use
ArrayEachto parse an array. The callback you can pass takes anerrorvalue as its argument and can't return one, meaning that even if you want to stop iterating, you can't. Additionally, the passed error can't be non-nil.If the error is not
nil, we'll run intoreturn offset, e. Sinceeisn't being reassigned before or after the call tocb, as go does't allow this with typeerror(value type), theif e != nil { break }is dead code anderrwill always benilinside of the callback.What were the thoughts behind the API design of this function? If I don't understand it, I think comments would be really helpful, both inline and function docs.