Repository navigation
Respect errors in cb function in ArrayEach and EachKey #53
Description
Activity
In our case probably better return
trueorfalse.This is about easier API vs some speed improvement for some (rare?) cases. Not sure if it will be useful for most of the users.
I agree, this is more generic as we could decide to stop iteration even if no error occurs, just because we got enough data.
Meanwhile I'm using following workaround:
result := []Foo{} var de error = nil err := jsonparser.ArrayEach(data, func(value []byte, dataType jsonparser.ValueType, offset int, err error) { if err != nil || de != nil { return } bars, err := extractBars(value) if err != nil { de = err return } append(result, Foo{FieldOne: jsonparser.GetString(value, "target"), Bars: bars}) })So given all this do we need
IterArray/IterKeyswith callback signaturecb func(value []byte, dataType ValueType, offset int, err error) bool?Ran into this issue today. I find it weird that it doesn't follow the same style of ObjectEach in this regard.
Reacted by Egor Shulakov, João Sousa Andrade and Clément Vannicatte- added a commit that references this issue
on Jul 28, 2026
Suppose we have following code:
We have no options to stop iterate over
dataeven if our functionextractBarswill return an error.I think there are two possible ways of fixing this issue.
1. If we don't care about backward compatibility
Just change cb signature to
cb func(value []byte, dataType ValueType, offset int, err error) error.2. If we respect backward compatibility
Then we could add counterpart for both there functions and name these like
IterArray,IterKeysor something like this.P.S.: In both cases I could contribute with PR.