Repository navigation
Fix skill installation across filesystems - #1020
Merged
Merged
Conversation
Stage extracted skills on the destination filesystem so installs and updates do not fail with an invalid cross-device link. Keep the existing skill until extraction succeeds and clean up staging paths. Fixes PB-3205 Amp-Thread-ID: T-01a11a01-3c61-7699-9bdf-622e05838dda
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 38167, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-6.1-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical pipeline paths). Human approval required unless repository policy explicitly allows L3 approval; per-PR grants cannot allow it.
Interrupted installs can leave staging directories in the skills folder. Exclude the staging prefix from update-all discovery so those directories do not cause a skill-not-found error. Amp-Thread-ID: T-01a11a01-3c61-7699-9bdf-622e05838dda
buildsworth-bk-app
Bot
dismissed
their stale review
October 8, 2026 06:28
Superseded by a newer Buildsworth review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes PB-3205.
bk skill addfails withinvalid cross-device linkwhen the temp and skills directories are on different filesystems.Stage extraction beside the destination so add and update succeed without a
TMPDIRworkaround. Includes regression tests.Testing
BUILDKITE_API_TOKENunset