Repository navigation
Return structured job data from job retry - #993
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0a3e8-c21d-725c-b208-9217f9c74e75 Co-authored-by: Amp <[email protected]>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
The implementation reuses the established output helpers, and the tests cover format precedence, the returned UUID, and API errors. This changes the default bk job retry output contract, so it falls outside the repository's low-risk approval ceiling and I'm leaving the review comment-only.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 28862, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical pipeline paths). Human review always required.
There was a problem hiding this comment.
No additional findings in this pass. The default bk job retry output contract changes, so I'm leaving final approval to a human.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 28863, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
|
@buildsworth-bk approve L2 |
|
@buildsworth-bk review please. Approve L2. |
2 participants
Description
bk job retrypreviously returned only a success message and URL, forcing callers to parse the URL or rediscover the new job.It now supports
--json,--yaml,--text, and--output, exposing the new job UUID directly:Output follows the configured format (JSON by default). Use
--textto preserve the previous success message.Testing