Repository navigation
Honor explicit organizations when listing builds and jobs - #995
Merged
Merged
Conversation
Do not borrow another organization’s stored identity or refresh an explicit environment token. Cover missing credentials and refresh ownership directly at the factory boundary. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a3e8-c21d-725c-b208-9217f9c74e75 Co-authored-by: Amp <[email protected]>
Fail before API requests when the target has no credentials, and explain how to authenticate it without silently selecting another identity. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a3e8-c21d-725c-b208-9217f9c74e75 Co-authored-by: Amp <[email protected]>
Distinguish a bare slug lacking organization context from malformed input, and offer a qualified pipeline or configuration as the remedy. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a3e8-c21d-725c-b208-9217f9c74e75 Co-authored-by: Amp <[email protected]>
Resolve the target before credential validation and creator lookup so requests and output agree without changing the selected organization. Exercise both listing commands through the same organization and authentication matrix. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a3e8-c21d-725c-b208-9217f9c74e75 Co-authored-by: Amp <[email protected]>
Make the no-fallback policy and login selection side effect explicit, with examples for targeting another organization without changing the default. Amp-Thread-ID: https://ampcode.com/threads/T-01a0a3e8-c21d-725c-b208-9217f9c74e75 Co-authored-by: Amp <[email protected]>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This changes which organization's stored credential is sent and when OAuth refresh can replace it, so it needs human sign-off. I found no code-level concerns.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 28994, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. Unless repository policy already allows L2 approval, grant it by mentioning @buildsworth-bk (see approval ceiling and L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only when repository policy or a verified grant allows it; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical pipeline paths). Human review always required.
scadu
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
acmeselected,bk build list --pipeline other/widgetscould queryacme/widgetsinstead. Job listing could similarly use the wrong organization or credentials.Qualified pipeline slugs and URLs now consistently determine the organization used for listing, creator lookup, credentials, and output, without changing the selected organization.
Changes
BUILDKITE_API_TOKENvalues remain authoritative and are never replaced by stored OAuth credentials after a 401Compatibility: users relying on cross-organization credential fallback must now run
bk auth login --org otheror explicitly supplyBUILDKITE_API_TOKEN.Testing
mise testpassesmise fmtran