Use REQUEST_URI instead of PATH_INFO (#18050) - #18059
Merged
Merged
Conversation
Switch to using REQUEST_URI (via diactoros/Uri) instead of reading from PATH_INFO. The PATH_INFO value includes URL decoding which can allow encoded URLs to match routes when they shouldn't. Remove urldecode in RouteCollection This was contributing to %2f getting through routing. We have to retain backwards compatibility with urlencoded path segements as users expect those to be exposed to application code in a decoded state. Backport of #18050 to 4.x
LordSimal
reviewed
Dec 6, 2024
Co-authored-by: Kevin Pfeifer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using REQUEST_URI (via diactoros/Uri) instead of reading from PATH_INFO. The PATH_INFO value includes URL decoding which can allow encoded URLs to match routes when they shouldn't.
Remove urldecode in RouteCollection
This was contributing to %2f getting through routing. We have to retain backwards compatibility with urlencoded path segements as users expect those to be exposed to application code in a decoded state.
Backport of #18050 to 4.x