Fix 19579 - #19582
Merged
Merged
Fix 19579#19582
Conversation
These classes no longer have valid base classes. I found these when reviewing the output from `i18n extract` in the test suite.
Correct a gap in source parsing logic that was not handling `Router::class` references which tokenize to ``` T_STRING, T_DOUBLE_COLON, T_CLASS. ``` By tracking the previous token type we can avoid this scenario from being treated as a class definition. Fixes #19579
ADmad
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct a gap in source parsing logic that was not handling
Router::classreferences which tokenize toBy tracking the previous token type we can avoid this scenario from being treated as a class definition. I've also removed several stub classes that no longer have base classes defined as these classes were also being caught in the stderr output.
Fixes #19579