Add DriverFeatureEnum for recently added driver specific behavior - #19619
Merged
Merged
Conversation
Add new cases to DriverFeatureEnum for recently added driver specific behavior related to subquery association loading. I'd like to avoid having driver specific logic in the ORM layer. We have Driver::supports() which allows us to model this driver specific behavior like we do for other driver/dialect specific feature support. Refs #19596 Refs #19552
markstory
force-pushed
the
maria-join-driver-enum
branch
from
September 13, 2026 03:00
d8bcdfb to
e0a8e02
Compare
ADmad
approved these changes
Sep 13, 2026
othercorey
reviewed
Sep 13, 2026
othercorey
reviewed
Sep 13, 2026
othercorey
reviewed
Sep 13, 2026
Co-authored-by: othercorey <[email protected]>
Member
Author
|
I'll fix the maria db failure separately it is broken on 5.x as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new cases to DriverFeatureEnum for recently added driver specific behavior related to subquery association loading. I'd like to avoid having driver specific logic in the ORM layer. We have Driver::supports() which allows us to model this driver specific behavior like we do for other driver/dialect specific feature support.
Refs #19596
Refs #19552