Skip to content

fix(docs): fix code example in docs - #1703

Merged
aearly merged 1 commit into
caolan:masterfrom
juanarbol:docs-changes
Feb 16, 2020
Merged

aearly merged 1 commit into
caolan:masterfrom
juanarbol:docs-changes

Conversation

@juanarbol

Copy link
Copy Markdown
Contributor

No description provided.

@aearly aearly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generated file. Can you fix in in the source?

@juanarbol

Copy link
Copy Markdown
Contributor Author

Sure.

@juanarbol
juanarbol force-pushed the docs-changes branch 2 times, most recently from 53a6892 to e734c8c Compare February 3, 2020 01:37
@juanarbol

Copy link
Copy Markdown
Contributor Author

I ran npm run jsdoc but a lot of files got modified, so I just left the source changed.

@juanarbol

Copy link
Copy Markdown
Contributor Author

Should I close this?

@aearly

aearly commented Feb 16, 2020

Copy link
Copy Markdown
Collaborator

No this is fine, i'll update it in the next release.

@aearly
aearly merged commit 2f329d0 into caolan:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants