Repository navigation
Conversation
Member
|
Than you, I'll look and test it soon! |
Collaborator
Author
|
It's only 5 lines - not the biggest PR :) I'd already written it so hopefully saved you a few mins |
Member
|
Sorry for a delay with this, I have this PR on a list of TODOs for next week. Thanks for the patience :) ( If you want to help me speed it up, I will appreciate if you add a comment justifying the need for this to the source code , before the if Enabled then
begin
{ Without doing SteamAPI_ISteamClient_BReleaseSteamPipe , an invalid behavior occurs when X.
Reproduce it by doing Y ... }
SteamAPI_ISteamClient_BReleaseSteamPipe(SteamClient, SteamPipeHandle);
SteamAPI_Shutdown();
end;Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #656
Small changes, add definition for SteamAPI_ISteamClient_BReleaseSteamPipe
Alter TCastleSteam.Destroy to call it in order to release the pipe (theoretically a resource leak)
No wrapping yet as it's only of any real use on Shutdown ATM (may be exposed later if required)