Repository navigation
Conversation
robertcoltheart
approved these changes
Oct 8, 2020
jonorossi
reviewed
Oct 8, 2020
jonorossi
left a comment
jonorossi
left a comment
Member
There was a problem hiding this comment.
Generally WindsorServiceProviderFactoryBase feels very fragile, it has virtual functions that expose each implementation detail so you can override whichever bits you'd like, looks like you'd have to read the code of this base class to know what to override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should use the container from the method call, not the root container
#557