Repository navigation
Conversation
aTom3333
force-pushed
the
bugfix/inode_cache_windows_index_truncation
branch
from
October 3, 2026 13:23
c3c4be7 to
036a1e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1827
I split the PR in multiple commits. The first one in the minimal fix, it uses the
ino_tfromDirEntrywhich is 64bits instead of the one from the Windows headers which is 16bits in the inode cache key. (And the the same fordev_tandoff_t).The second commit makes use of the full 128bits file ID as I mentioned in the issue is recommended by the documentation. It required bumping the Windows version (from Vista to Windows 8) and changing the type of
ino_tto be an array. If those change risk hurting compatibility, fell free to drop this commit, only the 64bits fix would already be better than status quo.The third commit is completely unrelated, just a fix to an assert I encountered during dev, fell free to drop.