Skip to content

Enhancement - Update build.ps1/build.netcore.ps1 to allow for building/packaging for subset of architectures #3706

Description

@amaitland

When building custom version of CefSharp it maybe desirable to only build/package a subset of the x86/x86/arm64 architectures. e.g. You may only wish to build x86/x64 for your custom version.

The nupkg process will fail if the files don't exist, so we need to perform some modifications dynamically.

To simplify this issue #3444 should likely be resolved first. I'm adding the breaking-change label, whilst this change in itself isn't breaking, the changes in #3444 will be.

Related issue cefsharp/cef-binary#98

Activity

  1. self-assigned this
    on Jul 22, 2021
  2. amaitland commented on Oct 12, 2021

    @amaitland
    MemberAuthor

    To simplify this the remaining c# projects have been migrated to the newer SDK Style project format in commit 67a08c4

  3. amaitland commented on Oct 12, 2021

    @amaitland
    MemberAuthor

    Tests are now failing when run via AppVeyor

    https://ci.appveyor.com/project/cefsharp/cefsharp/builds/41113154

  4. campersau commented on Oct 12, 2021

    @campersau
    Contributor

    It looks like the cef dependencies aren't copied to the output directory anymore (I can reproduce it by deleting the bin/obj folders before duing a build).

    Adding the following lines to https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Test/CefSharp.Test.csproj fixes it:

        <Target Name="CefCopy" AfterTargets="Build">
            <CallTarget Targets="CefRedist32CopyResources" Condition="'$(Platform)' == 'x86'"/>
            <CallTarget Targets="CefRedist64CopyResources" Condition="'$(Platform)' == 'x64'"/>
        </Target>

    Looks like this got removed here:
    67a08c4#diff-b6fc1d6d9c3d3eff95f339ef0f4455fbf23bf9bcb59d53500632de453f4f676dL11-L13
    67a08c4#diff-b6fc1d6d9c3d3eff95f339ef0f4455fbf23bf9bcb59d53500632de453f4f676dL16-L19

  5. amaitland commented on Oct 12, 2021

    @amaitland
    MemberAuthor

    I'll fix the errors shortly.

  6. amaitland commented on Oct 12, 2021

    @amaitland
    MemberAuthor

    The chromiumembeddedframework.runtime package is now used internally. Tests should now be passing again.

  7. added this to the 95.7.x milestone on Oct 13, 2021
  8. amaitland commented on Oct 13, 2021

    @amaitland
    MemberAuthor

    It should now be possible to compile only a subset of architectures

    .\build.ps1 -BuildArches "x64"
    .\build.ps1 -BuildArches "x64 x86"
    
    .\build.ps1 -BuildArches "x64" -TargetFramework NetCore
    .\build.ps1 -BuildArches "x64 x86" -TargetFramework NetCore
  9. added a commit that references this issue on Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions