Skip to content

Core - LoadUrlAsync require url and remove SyncContext param #3842

Closed
Closed
Core - LoadUrlAsync require url and remove SyncContext param#3842
Assignees
amaitland
Labels
breaking-change
Milestone
95.7.x

Description

@amaitland
amaitland
opened on Oct 10, 2021

Currently it's possible to call await browser.LoadUrlAsync() without passing in a Url.

If you do this and the browser isn't loading then the method will just wait forever.

To provide a predictable behaviour the string url = null will be changed to string url and an ArgumentNullException thrown when string.IsNullOrEmpty(url).

  • Remove default null value for url param.
  • Remove SyncronisationContext param
    upon remove it doesn't make sense
  • Add WaitForInitialLoadAsync method

Activity

  1. amaitland
    added
    breaking-change
    on Oct 10, 2021
  2. amaitland
    added this to the 95.7.x milestone on Oct 10, 2021
  3. amaitland
    added a commit that references this issue on Oct 10, 2021

    WinForms/WPF/OffScreen - Add WaitForBrowserInitialLoadAsync

    08e5140

  4. amaitland commented on Oct 10, 2021

    @amaitland
    amaitland
    on Oct 10, 2021
    MemberAuthor

    WaitForBrowserInitialLoadAsync has been added, still needs some additional testing.

    The intention of this method is to wait for the browser to finish it's initial load though it's not strictly checking for anything that prevents it from being called later.

    I might consider renaming to WaitForBrowserLoadAsync before the 95 branch is created.

  5. odo-leni
    added a commit that references this issue on Oct 15, 2021

    Squashed commit of the following:

    9e55773

  6. amaitland commented on Oct 22, 2021

    @amaitland
    amaitland
    on Oct 22, 2021
    MemberAuthor

    WaitForBrowserInitialLoadAsync has been added, still needs some additional testing.

    Was reverted as some of the tests failed.

  7. amaitland
    changed the title [-]Core - LoadUrlAsync require url[/-] [+]Core - LoadUrlAsync require url and remove SyncContext param[/+] on Oct 27, 2021
  8. amaitland
    added a commit that references this issue on Oct 27, 2021

    WinForms/WPF/OffScreen - Add WaitForBrowserInitialLoadAsync

    91b7514
  9. amaitland
    self-assigned this
    on Oct 28, 2021
  10. amaitland
    added 2 commits that reference this issue on Oct 28, 2021

    Core - Rename WaitForBrowserInitialLoadAsync to WaitForInitialLoadAsy…

    4a07af2

    Core - LoadUrlAsync require url and remove SyncContext param

    4112340

  11. amaitland commented on Oct 28, 2021

    @amaitland
    amaitland
    on Oct 28, 2021
    MemberAuthor

    For anyone using LoadUrlAsync() without params then you can switch to using WaitForInitialLoadAsync for the initial page load.

    //Before
await browser.LoadUrlAsync();
//After
await browser.WaitForInitialLoadAsync();
  12. amaitland
    added 3 commits that reference this issue on Oct 28, 2021

    WinForms/WPF/OffScreen - Add WaitForBrowserInitialLoadAsync

    3221c4b

    Core - Rename WaitForBrowserInitialLoadAsync to WaitForInitialLoadAsy…

    e8e6eb8

    Core - LoadUrlAsync require url and remove SyncContext param

    b0d19f7
  13. amaitland
    closed this as completedon Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

breaking-change

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions