Skip to content

csi: validate incoming VolumeGroupSnapshot requests - #5353

Merged
mergify[bot] merged 2 commits into
ceph:develfrom
nixpanic:rbd/groupcontroller/validation
Jun 5, 2025
Merged

mergify[bot] merged 2 commits into
ceph:develfrom
nixpanic:rbd/groupcontroller/validation

Conversation

@nixpanic

@nixpanic nixpanic commented Jun 5, 2025 •

Copy link
Copy Markdown
Member

Add missing validation for VolumeGroupSnapshot requests.

@nixpanic
nixpanic requested a review from a team June 5, 2025 11:48
@nixpanic
nixpanic force-pushed the rbd/groupcontroller/validation branch 2 times, most recently from 224398a to 1fd695e Compare June 5, 2025 12:15
@nixpanic nixpanic added the component/rbd Issues related to RBD label Jun 5, 2025

@Nikhil-Ladha Nikhil-Ladha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if "rbd" would have been a more appropriate commit title type for this change 🤔

@nixpanic

nixpanic commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

Wondering if "rbd" would have been a more appropriate commit title type for this change 🤔

It's actually both. This validation isn't really rbd specific, only that it is in the RBD group-controller. Because it is more of a CSI-verification, I through csi as component would be better.

@nixpanic

nixpanic commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Jun 5, 2025 •

Copy link
Copy Markdown
Contributor

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at e2be707

nixpanic added 2 commits June 5, 2025 12:41
Add missing validation for VolumeGroupSnapshot requests.

Signed-off-by: Niels de Vos <[email protected]>
@mergify
mergify Bot force-pushed the rbd/groupcontroller/validation branch from 1fd695e to b9ec9cb Compare June 5, 2025 12:41
@mergify mergify Bot added the ok-to-test Label to trigger E2E tests label Jun 5, 2025
@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.32

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.32

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.32

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 5, 2025
@mergify
mergify Bot merged commit e2be707 into ceph:devel Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/rbd Issues related to RBD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants