Repository navigation
Switch compiler macros to CONSTANT-FORM-VALUE instead of CL:EVAL - #345
Open
samuel-hunter wants to merge 3 commits into
Open
samuel-hunter wants to merge 3 commits into
samuel-hunter wants to merge 3 commits into
Conversation
samuel-hunter
force-pushed
the
use-constant-form-value
branch
from
November 8, 2022 00:22
20ed961 to
495f0fb
Compare
Contributor
Author
|
All uses of CL:EVAL are switched out except for the CFFI-SYS macros in
I'm leaning on option 1. Any thoughts? |
Member
|
8629618 refactors the package definitions and exports CONSTANT-FORM-P and CONSTANT-FORM-VALUE from CFFI-SYS. |
Contributor
Author
|
Switched out functions in cffi-sys. This should be ready for another round of reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP. Fixes #344.
CONSTANT-FORM-VALUE probably ought to belong in a separate package so that CFFI-SYS can access it without a circular dependency.