Repository navigation
When local .npmrc is found the action still says No .npmrc file found, creating one #89
Description
Activity
+1
Project here has the
.npmrc, but in changsets/action step also say “not found”.Action file is release.yml
This project has project-level
.npmrcfile - the log is about the lack of the user-level file.This project has project-level
.npmrcfile - the log is about the lack of the user-level file.yes, I known that, just will make a little confused
Reacted by Liam O'BoyleHow would you phrase this message to be less confusing? I'm open to suggestions.
maybe log with prefix “user-level”?
I believe that the issue was addressed some time ago. Please take a look at my comment here. If you still believe there is an issue with the latest code then please open a new issue describing the actual and expected results.
@Andarist I have opened a new issue #132 that relate to this issue with more deeper reason.
How would you phrase this message to be less confusing? I'm open to suggestions.
If there's a project level
.npmrcpresent then I would skip logging and creating the user level file, as AFAIK it's redundant and so the log makes it appear that something is wrong when it's probably fine.Feel free to open a PR with the suggested change and explanation behind it.
Reacted by Liam O'BoyleI've opened a PR with my thinking (see above), but noting for anyone else that comes past is that a workaround to silence the potentially confusing warning, if you're writing your own
.npmrc, is to write it to~/.npmrcinstead of./.npmrc.
Here's the repo where I have local
.npmrcwhich is being considered but the changesets action still says.Here's the output message from running action
I got confused that it isn't picking up local my
.npmrceven though it is. I think the messaging can be bit more contextual if it finds my local.npmrc. So I think we can change the messaging a bit.