Skip to content

Add runtime tests for null ptr arithmetic - #378

Merged
mgrang merged 1 commit into
masterfrom
dyn-check2
Aug 20, 2019
Merged

mgrang merged 1 commit into
masterfrom
dyn-check2

Conversation

@mgrang

@mgrang mgrang commented Aug 19, 2019

Copy link
Copy Markdown

No description provided.

@mgrang
mgrang requested a review from dtarditi August 19, 2019 23:45
@mgrang

mgrang commented Aug 19, 2019

Copy link
Copy Markdown
Author

This depends on checkedc/checkedc-clang#663

@dtarditi dtarditi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

I think we should add additional tests of the different kinds of variables. The tests currently only test global variables. In my experience with clang, clang can go down different paths for local variables and parameters, so it is important to test them. Please open an issue for that. This can be done as a separate PR.

@mgrang

mgrang commented Aug 20, 2019

Copy link
Copy Markdown
Author

we should add additional tests of the different kinds of variables. The tests currently only test global variables. In my experience with clang, clang can go down different paths for local variables and parameters, so it is important to test them.

Done checkedc/checkedc-clang#670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants