Skip to content
This repository was archived by the owner on Sep 23, 2025. It is now read-only.

Update loading-bar.js - #119

Closed
kurtommy wants to merge 1 commit into
chieffancypants:masterfrom
kurtommy:patch-1
Closed

kurtommy wants to merge 1 commit into
chieffancypants:masterfrom
kurtommy:patch-1

Conversation

@kurtommy

Copy link
Copy Markdown

Prevent loading bar jump back

Prevent loading bar jump back
@kurtommy kurtommy mentioned this pull request Sep 24, 2014
@chieffancypants

Copy link
Copy Markdown
Owner

Hmm, almost, but this doesn't account for the scenario when one XHR relies on the response from another.

In this scenario, a single XHR request goes out, the loading bar increments a bit, and when it comes back, the loading bar goes to 100%, but at the same time, another XHR request goes out using data it received from the first. In this case, the loading bar waits at 100% until receiving the second XHR response, so the experience is actually worse than the loading bar jumping backwards as it makes the UI feel like it froze.

This could probably be resolved by not setting the progress bar's width to 100% until the $timeout here completes.

@faceleg

faceleg commented Mar 16, 2016

Copy link
Copy Markdown
Collaborator

Closing due to inactivity.

@faceleg faceleg closed this Mar 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants