Repository navigation
Conversation
fix-for-issue-413-removewindowhandler-d-1644414580139 This error prevents to release the JNI Window Handler object
…dler The JNI object is retained in the "addHandler" method but was never released.
Collaborator
|
Please submit PRs against the upstream repository: https://bitbucket.org/chromiumembedded/java-cef |
Contributor
|
Done : |
Collaborator
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed 2 JNI object leaks.
The first in the CefClientHandler, one class name was not properly written, so the removeWindowHandler method didn"t work.
The second in CefMessageRouter_N, the handler was removed, but not its JNI reference.