Repository navigation
Conversation
It now passes dmabuf planes on Linux, as well as IOSurface pointer on macOS. It has also been refactored into multiple classes for each platform.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since my original pull request gained no further attention, even though we've been using this in production for ages, I decided to implement the remaining TODO. This pull request has partially been hallucinated together by Claude Opus 5.5.
Adds renderer support for
OnAcceleratedPaintinCefBrowserOsr, so the JOGL-based OSR browser draws accelerated frames whenshared_texture_enabledis set.JOGL does not expose the needed interop functions, so each platform gets a small JNI helper. The same import paths run in production in our MCEF renderer (LWJGL), while the JOGL implementation still needs testing on Windows and macOS:
glImportMemoryWin32HandleEXT(EXT_external_objects_win32)GLX_EXT_texture_from_pixmap, MCEF: EGLImageCGLTexImageIOSurface2D@magreenblatt macOS is included now.
Output is pixel-identical to the software path, popups included:
onPaintonAcceleratedPaintUse Squash And Merge.