Any gh command / any way to find the head-sha at the time of PR approval? #6615

Bikram-DoorDash · 2022-11-14T23:00:20Z

Bikram-DoorDash
Nov 14, 2022

A developer checks in some code in feature branch and creates a PR from that feature branch to "uat" branch. Even though it is not mandatory (i.e. not enabled in branch protections), someone reviews the PR and approves it. At this point, let's say head-sha is sha123.

And then the developer makes some more change in the feature branch, which automatically become part of this PR. At this point, the head-sha is sha124.

I am looking for a gh command or any way to find the head-sha at the time the PR was approved (sha123).
I need to write a script that compares head-sha at the time of approval with current head-sha, and return "fail" if they don't match.

I tried gh pr view ${PR_Number} --json commits,reviews . It does have a timestamp at submittedAt key. But that doesn't quite serve the purpose.

% gh pr view 16813 --json commits,reviews
{
  "commits": [
    {
      "authoredDate": "2022-11-14T21:38:25Z",
      "authors": [
        {
          "email": "[email protected]",
          "id": "kfvjfjdfkmvcj",
          "login": "FirLas",
          "name": "First Last"
        }
      ],
      "committedDate": "2022-11-14T21:38:25Z",
      "messageBody": "",
      "messageHeadline": "Update Account-Corp Dev.layout-meta.xml",
      "oid": "sha123"
    },
    {
      "authoredDate": "2022-11-14T21:40:59Z",
      "authors": [
        {
          "email": "[email protected]",
          "id": "kfvjfjdfkmvcj",
          "login": "FirLas",
          "name": "First Last"
        }
      ],
      "committedDate": "2022-11-14T21:40:59Z",
      "messageBody": "",
      "messageHeadline": "Again updated Account-Corp Dev.layout-meta.xml",
      "oid": "sha124"
    }
  ],
  "reviews": [
    {
      "id": "",
      "author": {
        "login": "bikram-agarwal"
      },
      "authorAssociation": "CONTRIBUTOR",
      "body": "",
      "submittedAt": "2022-11-14T21:40:06Z",
      "includesCreatedEdit": false,
      "reactionGroups": [],
      "state": "APPROVED"
    }
  ]
}

I can take this timestamp of the "approved" review and compare it with timestamp in the commits section; but that's a little bit "involved" process. And I'll have to write code for timestamp comparison. Instead, if I I had a way of getting the head-sha / "oid" at the time of the approval, it'd be a lot easier.

Answered by mislav

Nov 15, 2022

Hi, every GitHub PR review records the exact commit ID for which it was made. However, this information isn't exposed in gh pr view --json reviews due to an omission on our part.

To work around this, you can query the REST API:

gh api "repos/{owner}/{repo}/pulls/NUMBER/reviews"

View full answer

mislav · 2022-11-15T00:14:25Z

mislav
Nov 15, 2022

Hi, every GitHub PR review records the exact commit ID for which it was made. However, this information isn't exposed in gh pr view --json reviews due to an omission on our part.

To work around this, you can query the REST API:

gh api "repos/{owner}/{repo}/pulls/NUMBER/reviews"

1 reply

Bikram-DoorDash Nov 15, 2022
Author

Great. Thanks for the tip. That works beautifully.

Navigation Menu

Repository navigation

Any gh command / any way to find the head-sha at the time of PR approval? #6615

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 1 reply

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Any gh command / any way to find the head-sha at the time of PR approval? #6615

Uh oh!

Uh oh!

Bikram-DoorDash Nov 14, 2022

Replies: 1 comment · 1 reply

Uh oh!

mislav Nov 15, 2022

Uh oh!

Bikram-DoorDash Nov 15, 2022 Author

Bikram-DoorDash
Nov 14, 2022

Replies: 1 comment 1 reply

mislav
Nov 15, 2022

Bikram-DoorDash Nov 15, 2022
Author