gh pr comment --edit-last does not proceed if no comment already exists for the user #10370

Activity

1. EdouardF

   added

   enhancementa request to improve CLIa request to improve CLI

   on Feb 4, 2025
2. cliAutomation

   added

   needs-triageneeds to be reviewedneeds to be reviewed

   on Feb 4, 2025
3. EdouardF

   changed the title [-]`gh pr comment --édit-last` does not proceed if no comment already exists for the user[/-] [+]`gh pr comment --edit-last` does not proceed if no comment already exists for the user[/+] on Feb 4, 2025
4. jtmcg commented on Feb 4, 2025

   

   jtmcg

   on Feb 4, 2025

   Last edited by jtmcg

   Contributor

   More actions

   Hey @EdouardF, I could see how that might be a convenient addition to gh pr comment --edit-last. I think the right approach, here, is not to add this functionality natively to --edit-last, but instead add a flag for non-TTY use-cases and a prompt for TTY use cases.

   It's worth calling out that gh issue comment uses a lot of the same code, here, so we probably want to maintain parity between those two experiences. My proposed AC is below:

   Acceptance Criteria

   Given I have no comments on an existing PR
   when I run gh pr comment [<number> | <url> | <branch>] --edit-last --create-if-none --body <body> (non-interactively)
   then a comment is created instead of erroring

   Given I have no comments on an existing PR
   when I run gh pr comment [<number> | <url> | <branch>] --edit-last (interactively)
   then I am prompted that no comment exists and whether or not I'd like to create a new comment. If I select Y, then I have the same experience as though I ran gh pr comment [<number> | <url> | <branch>]

   Given I have no comments on an existing PR
   when I run gh pr comment [<number> | <url> | <branch>] --edit-last --create-if-none (interactively)
   then I am told that no comments exist and I am creating a new comment. Then I have the same experience as though I ran gh pr comment [<number> | <url> | <branch>]

   Given I have no comments on an existing issue
   when I run any of the above scenarios using gh issue comment
   then I have get the same behavior as I would running gh pr comment
   (i.e. make sure gh issue comment gets the same new functionality that's added to gh pr comment by the above AC)

   Notes

   • I think we can use a single opt to hold the flag value and use it for setting with the prompter.
   • We should probably make a new error for the condition where no comments exist and check for it in CommentableRun. We can then fall through to the createComment experience from here if the new flag is set. Note: this might be an oversimplification of the problem, but I wanted to bread-crumb the implementation of this
5. jtmcg

   added

   gh-prrelating to the gh pr commandrelating to the gh pr command

   help wantedContributions welcomeContributions welcome

   gh-issuerelating to the gh issue commandrelating to the gh issue command

   and removed

   needs-triageneeds to be reviewedneeds to be reviewed

   on Feb 4, 2025
6. BagToad

   self-assigned this

   on Feb 18, 2025
7. BagToad

   closed this as completedin #10427on Feb 19, 2025