Skip to content

GHE compatibility: git remote parsing #1181

Description

@mislav

Something we need to lift when working towards GHE compatibility #273 is the restriction that all git remotes need to point to github.com. Currently, we ignore all remotes that don't:

func FromURL(u *url.URL) (Interface, error) {
if !strings.EqualFold(u.Hostname(), defaultHostname) && !strings.EqualFold(u.Hostname(), "www."+defaultHostname) {
return nil, fmt.Errorf("unsupported hostname: %s", u.Hostname())

Respecting remotes that don't can give us more flexibility when detecting the 3rd-party hostname and deciding whether to authenticate against it with OAuth. #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementa request to improve CLI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions