Skip to content

GHE compatibility: generating URLs #1183

Description

@mislav

When thinking about GHE compatibility #273, we should address the different places where we generate URLs within CLI and ensure that we are respecting the current hostname that might be different from github.com.

  1. repo clone, repo fork, pr create, and other commands may generate git remote URLs. These URLs should not be hardcoded to github.com, but should respect whathever is the current or selected hostname.

  2. issue/pr/repo view --web and other commands may generate URLs for viewing in the browser. Same as above.

Ref. #1282

Activity

  1. vilmibm commented on Jun 23, 2020

    @vilmibm
    Contributor

    A fellow hubber pointed out it would be nice to have gh talk to a dev environment which I agree sounds really cool.

    I'm pretty sure this work will enable that without any change in course; is that your understanding too, @mislav ?

  2. mislav commented on Jun 25, 2020

    @mislav
    ContributorAuthor

    @vilmibm A support for any GitHub hosts will in theory be possible, even the one running on github.localhost, but there are some differences between GHE and localhost: namely that our OAuth app probably won't be registered in localhost and that the dev API server runs on http://api.github.localhost whereas GHE exposes API endpoints under https://HOSTNAME/api/.

    But I also think supporting dev environments would be cool, so let's try supporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementa request to improve CLI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions