gh issue create -R doesn't show issue templates #2361

Activity

1. camelid

   added

   bugSomething isn't workingSomething isn't working

   on Nov 5, 2020
2. divyaramanathan commented on Nov 6, 2020

   

   divyaramanathan

   on Nov 6, 2020

   Contributor

   More actions

   Hello! I might be interested in taking a deeper look at this; does your team have any resources or tips you'd recommend to get started? Thanks so much!

   👍React with 👍1Reacted by Zach Boyle
3. samcoe

   added

   enhancementa request to improve CLIa request to improve CLI

   help wantedContributions welcomeContributions welcome

   and removed

   bugSomething isn't workingSomething isn't working

   on Nov 16, 2020
4. samcoe commented on Nov 16, 2020

   

   samcoe

   on Nov 16, 2020

   Contributor

   More actions

   @camelid Good catch. I changed this to an enhancement since right now that is how the command is designed to work. We only check locally for issue templates, and when specifying the -R flag it is not required to have the repository cloned locally. The GraphQL API does expose repo issue templates though https://docs.github.com/en/free-pro-team@latest/graphql/reference/objects#issuetemplate so I don't see why we could not support handling this case.

   👍React with 👍2Reacted by Noah Lev and Divya Ramanathan
5. samcoe

   added

   coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributors

   and removed

   help wantedContributions welcomeContributions welcome

   on Nov 16, 2020
6. mislav

   added

   bugSomething isn't workingSomething isn't working

   help wantedContributions welcomeContributions welcome

   priority-2Affects more than a few users but doesn't prevent core functionsAffects more than a few users but doesn't prevent core functions

   and removed

   coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributors

   enhancementa request to improve CLIa request to improve CLI

   on Nov 16, 2020
7. mislav commented on Nov 16, 2020

   

   mislav

   on Nov 16, 2020

   Last edited by mislav

   Contributor

   More actions

   @divyaramanathan Sorry for the late reply! We would appreciate if someone like you could take a stab at this.

   There is now a Repository.issueTemplates GraphQL connection that returns a list of IssueTemplate objects. Our original templates implementation predates this API, so we opted to read the templates from disk instead. This, of course, does not work with -R.

   My preferred solution would be to use the API both when -R was passed and when it wasn't passed. See pkg/cmd/issue/create/create.go for existing code that uses githubtemplate, but should use API calls instead. You can try prototyping up these API calls!

   For pull request templates, we still have to read files from disk (i.e. use the old approach) because there is no Repository.pullRequestTemplates GraphQL API.

   @samcoe I've reclassified this as a bug, even though the original code is working as intended, since I feel that issue/PR templates should behave the same regardless of whether -R was used.

   👍React with 👍3Reacted by Noah Lev, Divya Ramanathan and Zach Boyle
8. divyaramanathan commented on Dec 3, 2020

   

   divyaramanathan

   on Dec 3, 2020

   Contributor

   More actions

   Hey @mislav and @samcoe! Apologies for the late reply to this, but finally took a stab at it!

   Myself and @zaboyle wrote up a GraphQL API call to get issue templates and are attempting to use these when creating issues from the command line. Our changes are in #2539 and we'd love to hear any and all feedback!

   Follow-up question: We noticed that the program was still defaulting to read files from the file system. How would you recommend calling the API appropriately? Thanks so much!

   👀React with 👀1Reacted by Sam Coe
9. mislav

   closed this as completedin #2539on Feb 17, 2021