Skip to content

gh pr merge --auto returns successfully when auto merging is not enabled on a repo #3367

Closed
Closed
gh pr merge --auto returns successfully when auto merging is not enabled on a repo#3367
Labels
blockedbugSomething isn't working

Description

@abatilo
abatilo
opened on Apr 6, 2021

Describe the bug

⇒  gh --version
gh version 1.8.0 (2021-03-30)
https://github.com/cli/cli/releases/tag/v1.8.0

Steps to reproduce the behavior

If you try to gh pr merge --auto on a repository that doesn't have auto merge enabled, the tool will still tell you that the PR will be merged once all checks have passed.

Expected vs actual behavior

I would expect the cli to tell me that it can't auto merge the PR since auto merging is not enabled on this PR.

Activity

  1. abatilo
    added
    bugSomething isn't working
    on Apr 6, 2021

  2. mislav commented on Apr 7, 2021

    @mislav
    mislav
    on Apr 7, 2021
    Contributor

    Thanks for reporting!

    I've reported this to the API team. I believe that the correct behavior should be that the server reports an error, but this isn't happening.

  3. mislav
    added
    blocked
    on Apr 7, 2021

  4. abatilo commented on Apr 7, 2021

    @abatilo
    abatilo
    on Apr 7, 2021
    Author

    I would agree! I think that an error would be much more reasonable behavior.

  5. mislav commented on May 21, 2021

    @mislav
    mislav
    on May 21, 2021
    Contributor

    This was since fixed on GitHub.com.

  6. mislav
    closed this as completedon May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    blockedbugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions