gh extension list is very slow #4220

Activity

1. waldyrious

   added

   bugSomething isn't workingSomething isn't working

   on Aug 27, 2021
2. mislav commented on Aug 30, 2021

   

   mislav

   on Aug 30, 2021

   Contributor

   More actions

   Listing extensions is slow because it checks on GitHub for every extension whether it has updates (i.e. has newer commits pushed)

   cli/pkg/cmd/extension/manager.go

   Lines 104 to 107 in 99cbfd3

   	if includeMetadata {
   	remoteUrl = m.getRemoteUrl(f.Name())
   	updateAvailable = m.checkUpdateAvailable(f.Name())
   	}

   We could probably speed it up by avoiding doing this check too often.
3. mislav

   added

   priority-2Affects more than a few users but doesn't prevent core functionsAffects more than a few users but doesn't prevent core functions

   on Aug 30, 2021
4. waldyrious commented on Aug 30, 2021

   

   waldyrious

   on Aug 30, 2021

   ContributorAuthor

   More actions

   We could probably speed it up by avoiding doing this check too often.

   IMO the default behavior should be to not do this check by default, and maybe print a message if the last check was too long ago, suggesting the user to run gh extension list --check (or whatever other flag name would be acceptable). That way, the slow behavior would be opt-in and deterministic, rather than "smartly" snuck in in some invocations of the command and not in others.

   👍React with 👍2Reacted by Benjamin Chadwick and atusy
5. samcoe

   self-assigned this

   on Oct 4, 2021
6. samcoe

   closed this as completedin #4396on Oct 12, 2021
7. waldyrious commented on Oct 20, 2021

   

   waldyrious

   on Oct 20, 2021

   Last edited by waldyrious

   ContributorAuthor

   More actions

   Hey @samcoe — I have had the chance to test gh 2.1.0, but even with this check for updates now done concurrently (thanks to #4396), it is still taking me several seconds to see the output (even more than before, ironically — although of course network latency variations will affect the results). As the original reporter, I would not consider this issue resolved until the times are much closer to a plain listing of ~/.local/share/gh/extensions/. Please reopen the issue.
8. samcoe commented on Oct 20, 2021

   

   samcoe

   on Oct 20, 2021

   Last edited by samcoe

   Contributor

   More actions

   @waldyrious Thanks for the update that you are still experiencing this issue. I will reopen it. As next steps for speeding this up I think the only real option is to try to reduce the number of network requests. Two options there are to do caching and only checking for updates every 24hr (for example) or introducing a flag that specifies that extension list should or shouldn't check for updates as you mentioned in your previous comment. We could also do a combination of both where the new flag will force a update check otherwise only check for updates on a specified interval.

   @mislav @vilmibm What are your thoughts?

   👍React with 👍1Reacted by Waldir Pimenta
9. samcoe

   reopened this on Oct 20, 2021
10. samcoe

    closed this as completedin #5098on Apr 12, 2022