Add support to manage issue/pull request/discussion locks #5020

Activity

1. glensc

   added

   enhancementa request to improve CLIa request to improve CLI

   on Jan 10, 2022
2. cliAutomation

   added

   needs-triageneeds to be reviewedneeds to be reviewed

   on Jan 10, 2022
3. mislav

   added

   discussFeature changes that require discussion primarily among the GitHub CLI teamFeature changes that require discussion primarily among the GitHub CLI team

   and removed

   needs-triageneeds to be reviewedneeds to be reviewed

   on Jan 11, 2022
4. mislav commented on Jan 11, 2022

   

   mislav

   on Jan 11, 2022

   Contributor

   More actions

   Note that you can currently lock/unlock issues via the gh api command:

   gh api -X PUT repos/{owner}/{repo}/issues/123/lock -f lock_reason=resolved
   
   gh api -X DELETE repos/{owner}/{repo}/issues/123/lock
   

   We could consider adding dedicated commands for this.

   👍React with 👍1Reacted by Elan Ruusamäe
5. darcyclarke

   removed

   discussFeature changes that require discussion primarily among the GitHub CLI teamFeature changes that require discussion primarily among the GitHub CLI team

   on Jan 19, 2022
6. darcyclarke

   assigned

   vilmibm

   on Jan 19, 2022
7. darcyclarke

   added

   coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributors

   on Jan 19, 2022
8. vilmibm commented on Jan 19, 2022

   

   vilmibm

   on Jan 19, 2022

   Contributor

   More actions

   Let's do this, adding unlock and lock to issue and pr.

   For whoever picks this up: to reduce boilerplating and test effort, support for this should be contained in a single new command (which can lock/unlock both issues and prs) mounted at the four places it's needed via cobra.

   If this is unclear, reach out to us for help.

   👍React with 👍1Reacted by Elan Ruusamäe

   🎉React with 🎉1Reacted by Elan Ruusamäe
9. vilmibm

   added

   help wantedContributions welcomeContributions welcome

   and removed

   coreThis issue is not accepting PRs from outside contributorsThis issue is not accepting PRs from outside contributors

   on Jan 19, 2022
10. chemotaxis commented on Jan 23, 2022

    

    chemotaxis

    on Jan 23, 2022

    Last edited by chemotaxis

    Contributor

    More actions

    I can take a look into this, if no one has started or claimed it.
11. chemotaxis commented on Jan 25, 2022

    

    chemotaxis

    on Jan 25, 2022

    Last edited by chemotaxis

    Contributor

    More actions

    @vilmibm

    After looking over the issue and pr commands, I have a couple questions:

    1. Conceptually, I understand that I should write a single function or command that gets aliased to lock and unlock. Where should I put that single function? I see that there are shared directories in both issue and pr. Should I be putting it one of those shared directories?
    2. Are there similar commands that I can take a look at that do similar functionality and api requests? I just want to make sure I'm using the correct modules for authentication, api requests, etc.
12. mislav commented on Feb 1, 2022

    

    mislav

    on Feb 1, 2022

    Last edited by mislav

    Contributor

    More actions

    @chemotaxis You can start a pkg/cmd/issue/lock package and have it export a method like NewCmdLock(). The method could take an argument to either "lock" or "unlock" and return a *cobra.Command. With that, you can mount that Cobra command four times: to issue lock, issue unlock, pr lock, and pr unlock.

    Sure, you could also add that method to the shared package, but I think having an explicit lock package in accordance to the naming scheme of other command implementations will make it more discoverable.
13. samcoe

    unassigned

    vilmibm

    on Apr 7, 2022
14. vilmibm

    closed this as completedin #5333on Dec 21, 2022