Repository navigation
Draft PR button not automatically selected when previewing on web #558
Description
Issue
Using version gh version 0.5.7 (2020-02-20)
The Create draft pull request button isn't automatically selected when previewing PR on the web, even though the -d or --draft flag is set on the gh pr create command.
Steps to reproduce the behavior
gh pr create -d- Add title and body
- View the output https://github.com/mm326/studious-bassoon/compare/master...branch2?expand=1&title=Draft+PR
Expected vs actual behavior
I expected that the create draft pull request button to be the default button when previewing a created pr from the cli when the -d flag is set.
Actual outcome:
Expected outcome:
Activity
rista404 commentedon Feb 27, 2020
Looks like GitHub doesn't support setting drafts via query params: Supported query parameters
mislav commentedon Feb 28, 2020
Since
-dcannot be translated to the web, I'm wondering what the right behavior would be here. Perhaps to error out and say that you can't use-dwith-w?mm326 commentedon Feb 29, 2020
Sorry for the late reply yeah that could be an option. I didn't specify the -w flag but entered preview in web which might of been a -w flag.
mislav commentedon Mar 11, 2020
Note that even though we've closed this issue, it's still technically allowed to use
--draftand select "Preview" in the prompt, which would then open the web interface and disregard--draftbeing passed. The referenced fix only covers the case when--draftwas used in combination with--web.Right now it's not technically possible for us to respect
--draftin "Preview" mode, but we're not sure how to best communicate this to the user. We don't want to abort the "Preview" operation at that point because that would discard the text that the person entered for PR title & body.