Skip to content

gh release edit: support --verify-tag like gh release create #7628

Description

@lidavidm

Describe the feature or problem you’d like to solve

gh release edit apparently can also create a tag, just like gh release create, if the tag does not exist. Just as with create, this isn't always desired.

Proposed solution

Add --verify-tag, which gh release create already supports, and note that this behavior is present.

Additional context

Originally added for create in #6566.

Activity

  1. samcoe commented on Jun 27, 2023

    @samcoe
    Contributor

    @lidavidm Thanks for the feature request. I am not opposed to it but could you elaborate a bit more on to when this feature would be useful to you? What is the scenario/workflow you are trying to improve?

  2. added
    more-info-neededMore info needed from user/contributor
    and removed on Jun 27, 2023
  3. lidavidm commented on Jun 27, 2023

    @lidavidm
    Author

    Ah, sorry.

    Here's concretely what we do: Apache Arrow ADBC, being an Apache project, first tags a commit for RC, then votes on it. If that passes we retag the commit. So there's a script that creates a tag and a prerelease on GitHub, and a script that creates the final tag and updates the release.

    When I forgot to push the final tag today, the final release instead unexpectedly pointed at main.

    Of course, it's reasonable to say that pushing the tag should be automated, too, avoiding the problem (other scripts of ours do this). So mostly I just found the behavior here surprising (I personally would've expected an error, and didn't realize it was intended behavior until I read the docs for create).

  4. samcoe commented on Jun 27, 2023

    @samcoe
    Contributor

    @lidavidm Thanks for the further explanation. I think this feature makes sense to add. I am going to open it up for community contributions.

  5. added and removed
    more-info-neededMore info needed from user/contributor
    on Jun 27, 2023
  6. rajhawaldar commented on Jun 29, 2023

    @rajhawaldar
    Contributor

    @samcoe I will take this ahead.

  7. lidavidm commented on Jul 7, 2023

    @lidavidm
    Author

    Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementa request to improve CLIhelp wantedContributions welcome

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions