Repository navigation
Consider adding some further debug information to gh run view --log #7643
Description
Activity
As @williammartin has already stated in this comment, there is also another potential case where a ZIP file contain nothing for the job run log (i.e., neither something like
0_jobname.txtnor-9999999999_jobname.txt, both at top-level). In such cases, if no step logs were also there, there'll be nothing to display to the user.
Describe the feature or problem you’d like to solve
Given the myriad issues relating to missing logs:
gh run view --logdoes not display logs when job names contain characters not allowed in file paths #7640gh run view --logwith duplicate job names incorrectly shows the same log twice #7641gh run view --logdoes not display logs when job names are beyond a certain length #7642It might be interesting to provide some mechanism to indicate when files in the
.zipwere not included in the log output. This would help CLI users and maintainers to uncover when there are missing logs, which logs are missing and why.Proposed solution
I don't have a good idea of how to do this from a UX point of view, perhaps leaning on
GH_DEBUGor having another flag would help.The consequence of whatever setting would be that if files in the
.zipwere not attached to therunLogwe would provide some indication why.My assumption here is that we know which files in the
.zipshould be included. I believe we do but I haven't seen all possible directory structures 🤷