Skip to content

Table headers are low contrast on default terminal app theme #8292

Description

@jwodder

Describe the bug

I am using gh 2.38.0 (installed via Homebrew) in macOS Sonoma's Terminal.app with a black-on-white theme. Styled text produced by gh is often very low-contrast against the background, and some searching pointed me to gh's GLAMOUR_STYLE environment variable for changing the colors. Unfortunately, no matter what I set GLAMOUR_STYLE to — light, dark, notty, or dracula — the output colors remain unchanged and unreadable.

Output from gh repo list (no GLAMOUR_STYLE):

default

Output from GLAMOUR_STYLE=light gh repo list:

light

Output from GLAMOUR_STYLE=dark gh repo list:

dark

Activity

  1. samcoe commented on Nov 6, 2023

    @samcoe
    Contributor

    Hi @jwodder sorry you are experiencing this, but I think there is a misunderstanding of the purpose of the GLAMOUR_STYLE environment variable. From gh help environment:

    GLAMOUR_STYLE: the style to use for rendering Markdown. See
    https://github.com/charmbracelet/glamour#styles

    The gh repo list command is not rendering markdown and thus the GLAMOUR_STYLE does not come into effect. Commands such as gh repo view do render markdown and you will be able to see the effect of changing that environment variable.

    Having said that I agree that the output you are seeing is quite low contrast. We just introduced the table headers so perhaps we need to pick a different color to use there. Are you using one of the default color schemes in the terminal app? Or is this a color scheme you found/created?

  2. added
    more-info-neededMore info needed from user/contributor
    and removed on Nov 6, 2023
  3. jwodder commented on Nov 6, 2023

    @jwodder
    Author

    @samcoe You're right, GLAMOUR_STYLE does indeed work for gh repo view.

    Having said that I agree that the output you are seeing is quite low contrast. We just introduced the table headers so perhaps we need to pick a different color to use there. Are you using one of the default color schemes in the terminal app? Or is this a color scheme you found/created?

    It's the unmodified builtin "Basic" theme (though it's possible the theme settings were carried over from an earlier macOS version and the theme now looks different in a fresh Sonoma install).

  4. added
    discussFeature changes that require discussion primarily among the GitHub CLI team
    priority-3Affects a small number of users or is largely cosmetic
    and removed
    more-info-neededMore info needed from user/contributor
    on Nov 7, 2023
  5. changed the title [-]`GLAMOUR_STYLE` not doing anything in Terminal.app[/-] [+]Table headers are low contrast on default terminal app theme[/+] on Nov 7, 2023
  6. andyfeller commented on Apr 15, 2025

    @andyfeller
    Contributor

    @jwodder : I wanted to circle back to this issue as v2.70.0 release has changes to natively fix this issue based upon the light / dark appearance of the background. If you had a moment, I'd appreciate your thoughts on the new experience as we strive to improve our user experience! 🙇

  7. jwodder commented on Apr 15, 2025

    @jwodder
    Author

    @andyfeller If I run gh repo list in a dark-on-light Terminal.app session, the results look fine:

    Image

    However, if I run the command inside a GNU Screen (v5.0.0) or tmux (v3.5a) session, gh seems to default to assuming a light-on-dark theme, which results in barely-visible table headers:

    Image

    Note that I've since changed my actual day-to-day terminal environment to light-on-dark, so either way, this issue doesn't effect me normally anymore.

  8. yousufmirpro commented on Apr 22, 2025

    @yousufmirpro
  9. added a commit that references this issue on May 10, 2025
  10. andyfeller commented on May 12, 2025

    @andyfeller
    Contributor

    @andyfeller If I run gh repo list in a dark-on-light Terminal.app session, the results look fine:

    Image However, if I run the command inside a GNU Screen (v5.0.0) or tmux (v3.5a) session, `gh` seems to default to assuming a light-on-dark theme, which results in barely-visible table headers: Image Note that I've since changed my actual day-to-day terminal environment to light-on-dark, so either way, this issue doesn't effect me normally anymore.

    @jwodder : Thank you for the follow up, here 🤔

    This second screenshot had the new accessible_colors setting / GH_ACCESSIBLE_COLORS env var set, correct? That or an older version would be the only reasons I could see the headers looking wrong here.

  11. jwodder commented on May 12, 2025

    @jwodder
    Author

    @andyfeller I did not set that envvar, nor have I done anything with that setting. I think I was using v2.68 of gh when I took those screenshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdiscussFeature changes that require discussion primarily among the GitHub CLI teamgh-reporelating to the gh repo commandpriority-3Affects a small number of users or is largely cosmetic

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions