Skip to content

pr create workflow broken by #8423 #8706

Description

@werkshy

Describe the bug

Relates #8423

In the latest release 2.44.0, the behavior of gh pr create has changed in a way that breaks my most common workflow. What I want to do is this: create a PR with sensible defaults for title and body (based on the commits) and edit the body before submitting it. This was the old default behavior, and when the branch only contained one commit, the PR title would be the commit headline. Now the default PR title is the branch name, which is rarely as descriptive.

I appreciate the --fill-verbose and --fill-first options, and would use them, but using any of the --fill* options leads to the PR being created straight away with no ability to edit the body.

$ gh --version
gh version 2.44.0 (2024-02-12)
https://github.com/cli/cli/releases/tag/v2.44.0

Steps to reproduce the behavior

  1. Have a branch with a single commit
  2. gh pr create or gh pr create --fill-first

Expected vs actual behavior

Expected behavior:

  • The PR title is set to the commit headline
  • We can edit the body locally before creating the PR

OR

  • We can use --fill-first or --fill-verbose to influence how the title and body are set
  • We can edit the body locally before creating the PR

Actual:

  • If no --fill* option is provided, the PR title defaults to the branch name
  • If a --fill* option is provided, there is no ability to edit the body, the PR is created instantly.

Activity

  1. added
    priority-2Affects more than a few users but doesn't prevent core functions
    gh-prrelating to the gh pr command
    and removed on Feb 16, 2024
  2. williammartin commented on Feb 16, 2024

    @williammartin
    Member

    Hey @werkshy, thanks for opening this issue. This is indeed an annoying regression, and I'm sorry we broke you!

    I think the right thing to do here is to fix the regression, rather than offer the opportunity to edit the fields after providing --fill*. I expect that we could fix this and get a patch release out today. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggh-prrelating to the gh pr commandpriority-2Affects more than a few users but doesn't prevent core functions

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions