Repository navigation
Conversation
|
I took a glance at this and I'm really excited about it, @iamazeem! I'm gonna chat with @williammartin about this tomorrow before giving you my review 🙂 |
|
Update after chatting with the team: Breaking this work upWe're going to take the original issue and break it into sub-issues so each subcommand is easier to follow and implement 🙌 We recently did something similar for Preferred command patternWe have a new pattern for commands that avoids adding http stubs to tests for anything besides http callers. This has been a major improvement in test confidence, readability, and extensibility, as it allows us for testing our functional interfaces more directly. You can see the pattern on display in the We'd like this command suite to also follow that pattern. It would be great if you could take a crack at it! I'll give a formal review once you work this out. Let me know if you're having issues and I can lend a hand. Providing supportWe think this is a valuable set of work and we will endeavor to provide you resources for getting this done. Thanks again! |
|
@jtmcg: Updated the PR accordingly. It's ready for review. Thanks! |
|
@jtmcg: Any update on this? |
|
Attaching the new sub-issue for this (working on writing up the others/translating the AC!): #10502 |
Thanks @RyanHecht! @iamazeem, can you take a look at the new issue and confirm you've satisfied all the AC? Once you do, I'll give this a review |
Related issue: #5149
Old AC: #5149 (comment)
Fixes #10502 with new AC.
API endpoints used
GET /repos/{owner}/{repo}/environmentsGET /repos/{owner}/{repo}/environments/{environment_name}/secretsGET /repos/{owner}/{repo}/environments/{environment_name}/variablesTests
bin/gh helpbin/gh help envbin/gh env list --helpbin/gh env list(no environments)bin/gh env list(with environments)bin/gh env list --json id,nameNotes
The token being used may not have all the required permissions.
For example:
/repos/{owner}/{repo}/environments(accessible)/repos/{owner}/{repo}/environments/{environment_name}/secrets(not accessible)Here's a sample run for a similar scenario for
cli/clirepo: