Skip to content

Quote filenames suggested at the end of worklow run - #11124

Closed
williammartin wants to merge 1 commit into
trunkfrom
11119-suggested-run-list-command-for-workflows-with-space-in-name-doesnt-work
Closed

williammartin wants to merge 1 commit into
trunkfrom
11119-suggested-run-list-command-for-workflows-with-space-in-name-doesnt-work

Conversation

@williammartin

Copy link
Copy Markdown
Member

Description

Fixes #11119

Copilot AI review requested due to automatic review settings June 16, 2025 16:06
@williammartin
williammartin requested a review from a team as a code owner June 16, 2025 16:06
@williammartin
williammartin requested a review from andyfeller June 16, 2025 16:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the suggested gh run list command to wrap workflow filenames in quotes.

  • In run.go, the format verb is changed from %s to %q to quote the filename.
  • In run_test.go, expected outputs are updated to include the new quotes.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/cmd/workflow/run/run.go Use %q to quote the workflow filename in the message
pkg/cmd/workflow/run/run_test.go Update test expectations to include quoted filenames

@williammartin
williammartin deleted the 11119-suggested-run-list-command-for-workflows-with-space-in-name-doesnt-work branch June 17, 2025 07:55

This branch was previously deployed

1 inactive deployment
cli-automation — da9ed6a3 Deployed Jun 16, 2025 by williammartin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested run list command for workflows with space in name doesn't work

2 participants