Repository navigation
Improvements to checking OAuth scopes - #1359
Merged
Merged
Conversation
`admin:org` is inclusive of `read:org`, so if we find the former listed in response headers, we can conclude that the token has necessary scopes instead of letting a warning notice be shown.
vilmibm
approved these changes
Jul 13, 2020
This was referenced Jul 15, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't warn about needing
read:orgscope if the current token hasadmin:orgscope. Fixes gh warns me that it requires read:org OAuth scope #1026Don't check required OAuth scopes if the response does not contain the
X-Oauth-Scopesheader at all, which silences the warning when gh is used in GitHub Actions withsecrets.GITHUB_TOKEN. Ref. Can't use GitHub CLI with GITHUB_TOKEN to mark PR as ready from GitHub Action #1314