Repository navigation
Isolate remaining old-style commands - #1500
Merged
Merged
Conversation
vilmibm
approved these changes
Aug 7, 2020
vilmibm
left a comment
vilmibm
left a comment
Contributor
There was a problem hiding this comment.
thank you so much for all this ;_;
Contributor
Author
|
@vilmibm I've also ported alias commands and expansion since you've last reviewed. Please take a look! Note that additional |
vilmibm
approved these changes
Aug 11, 2020
vilmibm
left a comment
vilmibm
left a comment
Contributor
There was a problem hiding this comment.
alias port looks great and i'm excited for the root reorganization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolated
issueand other remaining commands to their own packages. This resulted in a major cleanup in the oldcommand/root.goandcontextpackage. 🤘Fixes #759
TODO:
aliascommands and we're done!