Skip to content

respect GH_HOST when resolving remotes - #2301

Merged
vilmibm merged 4 commits into
trunkfrom
host-remote
Nov 19, 2020
Merged

vilmibm merged 4 commits into
trunkfrom
host-remote

Conversation

@vilmibm

@vilmibm vilmibm commented Oct 26, 2020 •

Copy link
Copy Markdown
Contributor

closes #1668

This pull request notices when GH_HOST has been set and then only resolves local remotes that match the set hostname. With this in place, a heterogeneous mix of hosts in a local remote file will not cause GH_HOST to be ignored.

An error is returned if the hostname specified in GH_HOST is not present in the local remotes.

@vilmibm
vilmibm requested a review from a team October 26, 2020 23:18

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

Comment thread pkg/cmd/factory/remote_resolver.go Outdated
Comment thread pkg/cmd/factory/remote_resolver.go Outdated
Comment thread pkg/cmd/factory/remote_resolver.go Outdated
Comment thread pkg/cmd/factory/remote_resolver.go Outdated

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow GH_HOST to select between hosts with mixed git remotes

2 participants