Skip to content

Add label list/create command - #5316

Merged
samcoe merged 11 commits into
cli:trunkfrom
ZaiZheTingDun:add-label-command
Mar 29, 2022
Merged

samcoe merged 11 commits into
cli:trunkfrom
ZaiZheTingDun:add-label-command

Conversation

@ZaiZheTingDun

Copy link
Copy Markdown
Contributor

The label list output will look like this, and could use -w flag to open on browser

image

Fixes #446

@ZaiZheTingDun
ZaiZheTingDun requested a review from a team as a code owner March 15, 2022 10:58
@ZaiZheTingDun
ZaiZheTingDun requested review from samcoe and removed request for a team March 15, 2022 10:58
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 15, 2022
@samcoe samcoe self-assigned this Mar 15, 2022

@samcoe samcoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZaiZheTingDun Thanks for getting this work started. I left a number of comments on the current direction, please let me know if you have any questions about them.

Comment thread pkg/cmd/label/create/create.go Outdated
Comment thread pkg/cmd/label/create/create.go Outdated
Comment thread pkg/cmd/label/create/create.go Outdated
Comment thread pkg/cmd/label/create/create.go Outdated
Comment thread pkg/cmd/label/list/list.go Outdated
@ZaiZheTingDun
ZaiZheTingDun requested a review from samcoe March 28, 2022 05:06
@samcoe

samcoe commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

@ZaiZheTingDun Thanks for taking on this work, it LGTM! I pushed a commit fixing up just a couple small things and adding some polish 💅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

label command

3 participants