Repository navigation
Add some git commands for usability testing - #54
Conversation
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Feature-wise, I find it kind of weird that gh add and gh commit are identical to git, while push and status are mostly similar but with extra functionality.
But I'm guessing that the point of including this in user testing is validating how users feel about this, so 👍
| err := gitCmd.Run() | ||
|
|
||
| if err != nil { | ||
| return errors.Wrap(err, "git failed") |
There was a problem hiding this comment.
I think that if we're simply proxying to git, we don't need to add extra error output on top of what git will already write to stderr.
That means we would also need to turn off automatic printing of the err object to stderr in main.go. Potential idea: we define a "SilentError" object in the command package and return that whenever we want to signal failure but when we don't want anything extra to be printed. Then in main.go:
if err != command.SilentError {
// print to stderr
}
os.Exit(1)There was a problem hiding this comment.
my hope is that this code doesn't last past the usability test; we can definitely come back to this if git proxying is to land in master.
2 participants
This PR consists of some code we wanted to put in front of users during usability testing to gauge responses to us proxying / augmenting some git commands.