Repository navigation
Add label list sorting and remove command - #5503
Conversation
|
This includes much of PR #5452 and I'll rebase onto trunk after that's merged. For now, take a look at https://github.com/cli/cli/pull/5503/files/d24e632f29c0ac12e69cee7c8323c6820a5978f9..HEAD. I figured given time zone difference, I'd give a head start for expediency. |
|
@heaths Thanks for getting this work started. I am still reviewing but I wanted to discuss the platform limitation regarding having both a search query and sort clause. As you suspected these two options are somewhat incompatible. I dove into the implementation and what is happening is that when there is a query phrase the platform uses elasticsearch to perform the search. Elasticsearch does its own scoring based on the search terms used and then will return the results based on best matches according to the score. Elasticsearch also supports sorting these results by With this information I think we have three options for moving forward with this:
What are your thoughts? |
|
I like 3 as well. Straight forward and would retain what I imagine is a match-based sort order by default. After all, it is a search, not a filter. I'll go ahead and make those changes. |
|
Rebased on trunk and removed the client-side sorting. |
samcoe
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments. This is ready to 🚢
Resolves #5489