Repository navigation
add and use ConfirmDeletion in {label,repo} delete - #6320
Merged
Merged
Conversation
vilmibm
force-pushed
the
label-prompter
branch
from
September 22, 2022 00:19
d4c2a22 to
d8a276e
Compare
mislav
approved these changes
Sep 26, 2022
| &result, | ||
| survey.WithValidator( | ||
| func(val interface{}) error { | ||
| if str := val.(string); !strings.EqualFold(str, requiredValue) { |
Contributor
There was a problem hiding this comment.
Nice that we're abstracting a convoluted Survey call behind a simple interface that takes just a string and returns an error 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new function to
surveyPrompter,ConfirmDeletion. It requires the user to type in a specific value in order to confirm that something should be deleted.I added it to
label deleteandrepo delete, the two places we seem to use that pattern.