Repository navigation
use Prompter in pr package - #6451
Merged
Merged
Conversation
added 4 commits
October 19, 2022 13:05
Note that this isn't done; it's leaving the metadata piece alone until better testing utils are in place
mislav
approved these changes
Nov 7, 2022
| }, | ||
| askStubs: func(as *prompt.AskStubber) { | ||
| as.StubPrompt("Where should we push the 'feature' branch?"). | ||
| AssertOptions([]string{"OWNER/REPO", "Create a fork of OWNER/REPO", "Skip pushing the branch", "Cancel"}). |
Contributor
There was a problem hiding this comment.
This used to verify all possible options shown to the user, and the new assertion doesn't do that anymore.
I do not think that every test should assert all available options, but it would be nice if at least some tests did.
samcoe
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts the code in
pkg/cmd/prto use the new Prompter. I did not port the metadata UI, however, as I want to wait until I've written better testing utils for Prompter.