Repository navigation
Prompt for owner when interactively creating repos - #6578
Merged
Merged
Conversation
cliAutomation
added
the
external
twelvelabs
commented
Nov 8, 2022
| if idx := strings.IndexRune(targetRepo, '/'); idx > 0 { | ||
| targetRepo = targetRepo[0:idx+1] + shared.NormalizeRepoName(targetRepo[idx+1:]) | ||
| if idx := strings.IndexRune(opts.Name, '/'); idx > 0 { | ||
| targetRepo = opts.Name[0:idx+1] + shared.NormalizeRepoName(opts.Name[idx+1:]) |
Contributor
Author
There was a problem hiding this comment.
Discovered this bug while testing. The confirmation prompt was mangling target names w/ org prefixes.
samcoe
self-requested a review
November 16, 2022 08:53
samcoe
approved these changes
Dec 5, 2022
Contributor
There was a problem hiding this comment.
@twelvelabs This looks great. Thanks for the well thought out feature and adding tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6574
Adds logic to prompt for an owner when interactively creating repos (following the logic agreed upon in #6574):