Repository navigation
Add --verify-tag flag for release creation command - #6632
Merged
Merged
Conversation
Fixes cli#6566 When running `gh release create <tag> --verify-tag`, we query <tag> among repository tags via the GitHub API before creating the release, and abort the command if the tag was not found.
luanzeba
commented
Nov 16, 2022
luanzeba
marked this pull request as ready for review
November 16, 2022 19:05
cliAutomation
added
the
external
mislav
suggested changes
Nov 16, 2022
mislav
left a comment
mislav
left a comment
Contributor
There was a problem hiding this comment.
This looks pretty good! Thanks
| } | ||
| } | ||
|
|
||
| var remoteTagPresent bool |
Contributor
There was a problem hiding this comment.
This variable can now be pushed into the following if block as its scope because it won't be needed elsewhere
Co-authored-by: Mislav Marohnić <[email protected]>
Co-authored-by: Mislav Marohnić <[email protected]>
luanzeba
force-pushed
the
gh_release_verify_tag
branch
from
November 16, 2022 20:12
1f9b64d to
fad72b7
Compare
Contributor
Author
|
Thanks for the quick review @mislav ! This is ready for another pass when you have a chance. Also let me know if you'd like me to squash the commits |
This was referenced Jul 14, 2026
This was referenced Jul 23, 2026
This was referenced Aug 4, 2026
Merged
This was referenced Aug 12, 2026
This was referenced Aug 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6566
When running
gh release create <tag> --verify-tag, we query among repository tags via the GitHub API before creating the release, and abort the command if the tag was not found.Things I'm not sure about
Disclaimer
I'm very new to Go and contributing to the cli project, so I welcome nit picky comments in the PR review as a learning opportunity.