Skip to content

More resilient release commands - #6667

Merged
mislav merged 4 commits into
trunkfrom
release-galore
Dec 19, 2022
Merged

mislav merged 4 commits into
trunkfrom
release-galore

Conversation

@mislav

@mislav mislav commented Nov 28, 2022 •

Copy link
Copy Markdown
Contributor

This changes the FetchRelease implementation to look up draft releases directly using by its pending tag name, as opposed to resorting to the Releases list API which is backed by Elastic Search and thus suffers replication lag after the creation of a draft release.

Bonus: all release lookup functions now accept a context for cancellation.
Enables up to 3 retries of uploading a single asset when encountering a network error or a HTTP 5xx error.

Bonus:
- simplifies ConcurrentUpload implementation
- support Go context cancellation
@mislav
mislav marked this pull request as ready for review December 14, 2022 21:11
@mislav
mislav requested a review from a team as a code owner December 14, 2022 21:11
@mislav
mislav requested review from samcoe and removed request for a team December 14, 2022 21:11
@mislav
mislav merged commit 7caf7da into trunk Dec 19, 2022
@mislav
mislav deleted the release-galore branch December 19, 2022 14:33
@vadimkantorov

vadimkantorov commented Dec 27, 2022 •

Copy link
Copy Markdown

I've also hit this problem, especially as part of my GitHub Actions. I hope there is now a retry option that will re-upload upload-failed assets:

Post "https://uploads.github.com/repos/busytex/busytex/releases/87303640/assets?label=&name=busytex": http2: client connection force closed via ClientConn.Close

I've also hit the same problem with hub, and I hoped it would be fixed in gh: mislav/hub#3027

When will this fix be released to alpine edge? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed gh release create with files leaves behind a draft release

3 participants