Repository navigation
Fix clobbering old files in release download - #6694
Merged
Merged
Conversation
Ensures that the old file to be clobbered is first truncated before writing.
samcoe
approved these changes
Dec 8, 2022
samcoe
left a comment
samcoe
left a comment
Contributor
There was a problem hiding this comment.
Great. I like that you were able to add tests for this functionality.
DavidC-TRT
reviewed
Dec 8, 2022
| } | ||
|
|
||
| func Test_downloadRun_cloberAndSkip(t *testing.T) { | ||
| oldAssetContents := "older copy to be clobbered" |
There was a problem hiding this comment.
Might possibly be worth making it clear in the test that this 'old' contents needs to be larger than the new download for the test to be valid. Incase someone modifies 'somedata' in the future.
Contributor
Author
There was a problem hiding this comment.
Thanks! Good thought.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the old file to be clobbered is first truncated before writing.
Fixes #6693