Repository navigation
Conversation
cliAutomation
added
the
external
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me
|
@mislav I realized there's a bunch of other fields that could be added to |
samcoe
left a comment
samcoe
left a comment
There was a problem hiding this comment.
@mgabeler-lee-6rs Thanks for the contribution, the code looks good to me. I pushed a small commit to address some style nits that I had. I am going to merge this one and we can address adding other fields in a follow up PR.
|
I did a closer look and the "other fields" I was hoping to add aren't present in the REST API, only the GraphQL API. That seems like a rather chunky change to make, and more difficult to test for backwards compatibility |
4 participants
The
gh pr view --json ...allows returning theisDraftfield, butgh search prsdoes not. This adds that option to the search command to match the view command.