Skip to content

Add --allow-update-branch to the repo edit command - #6706

Merged
mislav merged 1 commit into
cli:trunkfrom
browniebroke:feat/edit-repo/allow-update-branch
Dec 20, 2022
Merged

mislav merged 1 commit into
cli:trunkfrom
browniebroke:feat/edit-repo/allow-update-branch

Conversation

@browniebroke

@browniebroke browniebroke commented Dec 8, 2022 •

Copy link
Copy Markdown
Contributor

Fixes #6708

@browniebroke browniebroke left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ad this stage it is only adding the command line flag, but I realise that there is also an interactive mode. Not sure it's worth adding. Are you guys intending to support all flags on the interactive mode?

@browniebroke
browniebroke marked this pull request as ready for review December 8, 2022 22:15
@browniebroke
browniebroke requested a review from a team as a code owner December 8, 2022 22:15
@browniebroke
browniebroke requested review from samcoe and removed request for a team December 8, 2022 22:15
@cliAutomation

Copy link
Copy Markdown
Contributor

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Dec 8, 2022
@browniebroke

Copy link
Copy Markdown
Contributor Author

Going to close this until it's discussed in #6708

@mdislam1212

This comment was marked as spam.

@browniebroke browniebroke reopened this Dec 20, 2022

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@mislav
mislav merged commit 2ede673 into cli:trunk Dec 20, 2022
@browniebroke
browniebroke deleted the feat/edit-repo/allow-update-branch branch December 20, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to set/unset "Always suggest updating pull request branches" in repo edit

4 participants